feat: Allow finding the base path when a laravel folder organisation … #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for providing and maintaining so much quality code. I ran across something when I updated some of our internal packages to use the laravel-package-tools. Some of them follow Laravels app folder structure, i.e. they have the provider in a Providers folder. The package tools assume the provider lives in the src root and automatically sets the Providers folder as the base path. This results in pretty much everything not being found (out of the box) and requires each package to call
setBasePath.This PR adds a check in
getPackageBaseDir()to see whether the path found ends in/Providersand if so, takes its parent folder as the base path. As I have seen the structuring of a package like Laravels app folder in other project too, I thought this PR might be useful to others too. Curious to learn what you think!