fix: add top-level author to json feed (#189)

spatie · May 27, 2022 · e879dce · e879dce
1 parent d2c5839
commit e879dce
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/resources/views/json.blade.php b/resources/views/json.blade.php
@@ -7,6 +7,12 @@
 @if(!empty($meta['image']))
     "icon": "{{ $meta['image'] }}",
 @endif
+    "authors": [@foreach($items->unique('authorName') as $item){
+            "name": "{{ $item->authorName }}"
+        }@if(! $loop->last),@endif
+@endforeach
+
+    ],
     "items": [@foreach($items as $item){
             "id": "{{ url($item->id) }}",
             "title": "{{ $item->title }}",
@@ -29,7 +35,7 @@
             ],
 @endif
             "tags": [ {!! implode(',', array_map(fn($c) => '"'.$c.'"', $item->category)) !!} ]
-        }@if($item !== $items->last()),
+        }@if(! $loop->last),
 @endif
         @endforeach
 

diff --git a/tests/__snapshots__/FeedTest__all_feed_items_have_expected_data__5.txt b/tests/__snapshots__/FeedTest__all_feed_items_have_expected_data__5.txt
@@ -5,6 +5,10 @@
     "feed_url": "http://localhost/feedBaseUrl/feed1.json",
     "language": "en-US",
     "icon": "http://localhost/image.jpg",
+    "authors": [{
+            "name": "feedItemAuthor"
+        }
+    ],
     "items": [{
             "id": "http://localhost/1",
             "title": "feedItemTitle",