-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy Files From External Storage To Local Storage for Import #149
base: main
Are you sure you want to change the base?
Conversation
@freekmurze anything i have to do fo a merge? |
ea3a2ae
to
9c96295
Compare
9c96295
to
1363232
Compare
Could you rebase against |
@freekmurze I think now it looks better ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could a test be added that makes sure that this code works?
66f841a
to
68adf55
Compare
68adf55
to
d5d2d34
Compare
Please don't forget adding the proper types in your method definitions (return and parameter). |
d5d2d34
to
34b6a76
Compare
|
@xHeaven Done i think |
@freekmurze anything to do for me? |
Hi i had some promblems loading Snapshots gzipped from S3.
So i implementent this solution where i first copy the file to local tmp Folder.
This solution works for me quite well