Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Arrayable when casting to DataCollection #577

Merged
merged 2 commits into from
Oct 12, 2023
Merged

feat: support Arrayable when casting to DataCollection #577

merged 2 commits into from
Oct 12, 2023

Conversation

innocenzi
Copy link
Contributor

This pull request adds support for casting Collection instances to DataCollection.

I had to use ->toArray in multiple scenarios when using DataCollection casts, but I think that should be handled by laravel-data directly.

@rubenvanassche
Copy link
Member

Thanks!

@rubenvanassche rubenvanassche merged commit c695f0d into spatie:main Oct 12, 2023
11 checks passed
@innocenzi innocenzi deleted the feat/support-arrayable-in-data-collections branch October 12, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@innocenzi @rubenvanassche