Bug Fixed EventLogBag modification pipe's interaction with different models #1304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
LogsActivity::$changesPipes
isstatic
, this stays in memory and interacts with other model's events.Scenario :
I used the below function to add more
LoggablePipe
to modify myEventLogBag
, but this was keeping theLoggablePipe
s into the memory and thoseLoggablePipe
s were modifying the other model's eventEventLogBag
s.So, I've cleared the
LoggablePipe
s after each log write. Simply addedas it has by default, that fixed my issue.