Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Maldivian holidays #229

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Add Maldivian holidays #229

merged 3 commits into from
Jun 14, 2024

Conversation

ahmedmansoor
Copy link
Contributor

No description provided.

@Nielsvanpach
Copy link
Member

Nielsvanpach commented Jun 13, 2024 •
edited
Loading

Thanks! Could you have a look at the failing phpstan checks?

@ahmedmansoor
Copy link
Contributor Author

Will check on the checks again 👌

@Nielsvanpach
Copy link
Member

You can run vendor/bin/phpstan analyse locally to see the results

@ahmedmansoor
Copy link
Contributor Author

The issues are in Countries\Benin and Countries\Morocco.
Should I address those in this PR?

You can run vendor/bin/phpstan analyse locally to see the results

@Nielsvanpach
Copy link
Member

Feel free to fix those. I'll merge your PR already in the meantime. Thanks for your work!

@Nielsvanpach Nielsvanpach merged commit dc17581 into spatie:main Jun 14, 2024
13 of 14 checks passed
@ahmedmansoor
Copy link
Contributor Author

Feel free to fix those. I'll merge your PR already in the meantime. Thanks for your work!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmedmansoor @Nielsvanpach