Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add holidays for Ecuador #218

Merged
merged 14 commits into from
Apr 11, 2024
Merged

Conversation

insoutt
Copy link
Contributor

@insoutt insoutt commented Apr 9, 2024

Contributing a new country ?

  • Have you checked to ensure there aren't other open Pull Requests for the same country?
  1. Create a new class in the Countries directory. It should extend the Country class.
  2. Add a test for the new country in the tests directory.
  3. Run the tests so a snapshot gets created.
  4. Verify the result in the newly created snapshot is correct.

My second commit is related following the rules of #219

Copy link
Member

@Nielsvanpach Nielsvanpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/Countries/Ecuador.php Show resolved Hide resolved
src/Countries/Ecuador.php Show resolved Hide resolved
src/Countries/Ecuador.php Outdated Show resolved Hide resolved
src/Countries/Ecuador.php Show resolved Hide resolved
src/Countries/Ecuador.php Outdated Show resolved Hide resolved
tests/Countries/EcuadorTest.php Show resolved Hide resolved
Copy link
Member

@Nielsvanpach Nielsvanpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Nielsvanpach Nielsvanpach merged commit bfa7b5f into spatie:main Apr 11, 2024
1 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants