Merge pull request #7 from jonasva/jonasva-patch-date-based-cache

Determine cache name based on formatted date
spatie · Mar 13, 2015 · 69036c0 · 69036c0
2 parents aabec11 + ff6f51b
commit 69036c0
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/AnalyticsReports.php b/src/AnalyticsReports.php
@@ -260,12 +260,14 @@ public function getSiteIdByUrl($url)
      */
     public function performQuery($startDate, $endDate, $metrics, $others = array())
     {
-        $cacheName = $this->determineCacheName(func_get_args());
+        $startDate = $startDate->format('Y-m-d');
+        $endDate = $endDate->format('Y-m-d');
+        $cacheName = $this->determineCacheName(array($startDate, $endDate, $metrics, $others));  
 
         if ($this->useCache() AND Cache::has($cacheName)) {
             $answer = Cache::get($cacheName);
         } else {
-            $answer = $this->client->query($this->siteId, $startDate->format('Y-m-d'), $endDate->format('Y-m-d'), $metrics, $others);
+            $answer = $this->client->query($this->siteId, $startDate, $endDate, $metrics, $others);
             if ($this->useCache()) {
                 Cache::put($cacheName, $answer, $this->cacheLifeTimeInMinutes);
             }