Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v20 of node #196

Merged
merged 2 commits into from
Aug 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/releases.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version-file: '.node-version'

- name: Extract branch name
shell: bash
run: echo "##[set-output name=branch;]$(echo ${GITHUB_REF#refs/heads/})"
Expand Down Expand Up @@ -49,4 +53,4 @@ jobs:
title: "Update examples"
body: "*This is an automated pull request because we found that the examples were out of date.*"
reviewers: sparksp
assignees: sparksp
assignees: sparksp
16 changes: 16 additions & 0 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version-file: '.node-version'

- uses: actions/cache@v4
id: yarn-cache
with:
Expand Down Expand Up @@ -47,6 +51,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version-file: '.node-version'

- uses: actions/cache@v4
id: yarn-cache
with:
Expand Down Expand Up @@ -80,6 +88,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version-file: '.node-version'

- uses: actions/cache@v4
id: yarn-cache
with:
Expand Down Expand Up @@ -114,6 +126,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version-file: '.node-version'

- uses: actions/cache@v4
id: yarn-cache
with:
Expand Down
1 change: 1 addition & 0 deletions .node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20
16 changes: 0 additions & 16 deletions tests/Tests/UseCamelCase.elm
Original file line number Diff line number Diff line change
Expand Up @@ -319,22 +319,6 @@ age =
|> Review.Test.expectErrors
[ variableError "person_age" "personAge"
]
, test "should report when uncons names are not camelCase and hint the correct name" <|
\_ ->
"""
module A exposing (..)
age =
let
person_age :: other_ages = ages
firstCamel :: otherCamels = allCamels
in
1
"""
|> Review.Test.run (rule default)
|> Review.Test.expectErrors
[ variableError "person_age" "personAge"
, variableError "other_ages" "otherAges"
]
, test "should report when list names are not camelCase and hint the correct name" <|
\_ ->
"""
Expand Down
Loading