Update to latest htmlunit neko #2856
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which should allow us to swap out the implementation of HTML with neko
|
I had a look at this but it's probably a bit too involved for my xerces and nokogiri/htmlunit knowledge. Was your thinking to essentially have two xerces versions eventually packaged? (Retain the mainline org.apache one as well as the shaded, refactored/simplified one inside htmlunit)? It looks like nokogiri seems to try and reuse the same xerces xonfiguration for its own direct stuff as well as for use by htmlunit so seemed to require a change to the configuration approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
This is a WIP for #2565. Feedback and help welcome.