wip: use xmlsec's noxxe entity loader #2654
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this segfaults with seed 12441 and I have not yet been able to track it down
|
This branch has been segfaulting with seed 12441. I've pushed a commit that resets the external entity loader before the call that was segfaulting (in the HTML4 SAX parser context) and the segfault stops. This tells me that we're not resetting the loader state properly after every call, this may be another instance of problems caused by raising errors - see #1610 and #2096. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to try to use xmlsec's noxxe entity loader when
NONETis set -- thereby makingNONETshut off not just network access, but all access to external resources.See #1582 for context.