Add Jibri work in progress #739

pcorace · 2020-11-29T00:05:19Z

[WIP] I'm working on adding jibri to the jitsi role.
I did not add host preparation tasks for Jibri to the playbook at the moment. (I did them manually on my host).
-ansible-playbook -i inventory / hosts setup.yml --tags = setup-jitsi, start -
ends without errors, but I must be missing some configuration because the recordings are not working.
The only weird thing I see in the logs is:
org.jitsi.xmpp.extensions.DefaultPacketExtensionProvider.parse () Could not add a provider for element busy-status from namespace http://jitsi.org/protocol/jibri
I leave it here to see if someone finds the error. (I already have my eyes crossed ... ha)

spantaleev · 2020-11-29T08:45:02Z

This may also be missing matrix_jitsi_enable_recording: true.

Since yesterday (e0d7d5f), we no longer enable recording by default, because it's not like Jibri was there for it to work anyway (see #726).

I think that when this PR lands, we should define matrix_jitsi_enable_recording in terms of matrix_jitsi_jibri_enabled (or vice versa), so that toggling one would be enough.

teutat3s

Thank you for starting to work on this and sharing this WIP! I think this is a nice addition to the playbook.

We could probably simplify this even more, because a lot of auto-configuration is already included in the https://github.com/jitsi/docker-jitsi-meet project.
For example, prosody already sets up its config for recording with Jibri when
https://github.com/jitsi/docker-jitsi-meet/blob/77aafe0573807e790013fecfaf84fb2c4f41980c/prosody/rootfs/defaults/conf.d/jitsi-meet.cfg.lua#L71
is set, which we already do here

matrix-docker-ansible-deploy/roles/matrix-jitsi/templates/prosody/env.j2

Line 30 in e0d7d5f

XMPP_RECORDER_DOMAIN={{ matrix_jitsi_recorder_domain }}

That means the file roles/matrix-jitsi/templates/jibri/jibri.cfg.lua.j2 shouldn't be necessary.

If I'm not mistaken, the only things we should need to do is add a jibri container and set its env correctly, which looks good to me already in this PR, and then set the ENABLE_RECORDING env to 1 in the web container, so that the Start recording button in the web UI becomes visible. Our var matrix_jitsi_enable_recording already takes care of this here:

matrix-docker-ansible-deploy/roles/matrix-jitsi/templates/web/env.j2

Line 30 in e0d7d5f

ENABLE_RECORDING={{ 1 if matrix_jitsi_enable_recording else 0 }}

teutat3s · 2020-11-29T12:30:28Z

roles/matrix-jitsi/tasks/main.yml

@@ -37,3 +41,9 @@
  tags:
    - setup-all
    - setup-jitsi
+
+- import_tasks: "{{ role_path }}/tasks/setup_jitsi_jibri.yml"
+  when: run_setup|bool


I wonder if all these when here should be like above:

when: "run_setup|bool and matrix_jitsi_enabled|bool"

Could be done in a separate PR as it's probably unrelated. Every task under setup_jitsi_jibri has sufficient checks.

teutat3s · 2020-11-29T12:35:09Z

roles/matrix-jitsi/templates/jibri/config.json.j2

+		// MUST be unic for every instanse
+                "nickname": "jibri-instanse-1"


Typos: unique & instance

teutat3s

So the unneeded files that get auto-generated at the containers first start via the env file would be:

roles/matrix-jitsi/templates/jibri/config.json.j2
roles/matrix-jitsi/templates/jibri/jibri.cfg.lua.j2
roles/matrix-jitsi/templates/jibri/logging.properties.j2

teutat3s · 2020-11-29T13:17:14Z

roles/matrix-jitsi/templates/jibri/matrix-jitsi-jibri.service.j2

+ExecStart={{ matrix_host_command_docker }} run --rm --name matrix-jitsi-jibri \
+			--log-driver=none \
+			--network={{ matrix_docker_network }} \
+			--env-file={{ matrix_jitsi_jibri_base_path }}/env \
+            --device=/dev/snd:/dev/snd \
+			--mount type=bind,src={{ matrix_jitsi_jibri_config_path }},dst=/config \
+			{% for arg in matrix_jitsi_jibri_container_extra_arguments %}
+			{{ arg }} \
+			{% endfor %}
+			{{ matrix_jitsi_jibri_docker_image }}


These should probably be added here, too
https://github.com/jitsi/docker-jitsi-meet/blob/77aafe0573807e790013fecfaf84fb2c4f41980c/jibri.yml#L9-L12

teutat3s · 2020-11-29T13:29:41Z

group_vars/matrix_servers

@@ -676,6 +676,7 @@ matrix_jitsi_jvb_container_colibri_ws_host_bind_port: "{{ '' if matrix_nginx_pro
 matrix_jitsi_jibri_xmpp_password: "{{ matrix_synapse_macaroon_secret_key | password_hash('sha512', 'jibri') | to_uuid }}"
 matrix_jitsi_jicofo_auth_password: "{{ matrix_synapse_macaroon_secret_key | password_hash('sha512', 'jicofo') | to_uuid }}"
 matrix_jitsi_jvb_auth_password: "{{ matrix_synapse_macaroon_secret_key | password_hash('sha512', 'jvb') | to_uuid }}"
+matrix_jitsi_jibri_recorder_password: "{{ matrix_synapse_macaroon_secret_key | password_hash('sha512', 'recorder') | to_uuid }}"


It seems to me that matrix_jitsi_jicofo_component_secret is still missing here?

@spantaleev - don't know if here or inventory/scripts/jitsi-generate-passwords.sh is the desired place to generate all passwords?

pcorace · 2020-11-29T14:09:07Z

Thank you @spantaleev for your clarification and thank you very much @teutat3s for your extensive review!
I'll get to work on your suggestions.
(Sorry for my English, I am Argentine and I usually speak Spanish)

ffuentes · 2021-01-31T18:17:56Z

@pcorace Hello do you know if this on WIP?

I have just deployed a matrix server with this ansible playbook, defined matrix_jitsi_jibri_recorder_password and matrix_jitsi_jibri_xmpp_password in my custom vars but can't record any video.

Thanks in advance.

Most of the work is done [here](spantaleev#739).

akshaylive · 2021-03-04T09:09:35Z

I've made some modifications on a fork here

With this, the Jibri container doesn't crash and connects to the XMPP server but does not work.

pcorace · 2021-03-04T13:40:49Z

Hello @ffuentes and @akshaylive . I had some problems in my work that kept me away from this project. This wip is out of date and Jibri is not working. I try to resume the project in the next few days. Any collaboration or comment is welcome.

akshaylive · 2021-03-06T04:00:55Z

Hello @ffuentes and @akshaylive . I had some problems in my work that kept me away from this project. This wip is out of date and Jibri is not working. I try to resume the project in the next few days. Any collaboration or comment is welcome.

Thanks for the effort put in! I do need your help with testing this fork. I am running my instance on the cloud VM and I do not have access to snd module. Specifically, on your machine, do you have a file called /dev/snd/pcmc0d0c? If so, it might work. I can see logs of Jibri connecting to prosody but is unable to record for an unknown reason.

pcorace · 2021-03-06T18:53:35Z

@akshaylive you need to set up an ALSA loopback device on the host according to the instructions at: https://jitsi.github.io/handbook/docs/devops-guide/devops-guide-docker#jitsi-broadcasting-infrastructure-jibri -configuration.
Anyway I don't think Jibri works. I think you have to add something to the nginx setup for the recordings to work.
I am going to analyze it. If I can get Jibri working I update this WIP.

Most of the work is done [here](spantaleev#739).

hungrymonkey · 2021-08-23T03:42:50Z

Damn it, how do i turn off these notification? They only annoy people. I am sorry for cherry-picking.

hungrymonkey · 2021-08-23T03:49:25Z

Hi everyone. If anyone needs to install a generic kernel for Debian 11 on AWS, I am attaching this ansible below. The ansible assumes a clean environment with only the cloud aws kernel installed.

lsb_release -a
No LSB modules are available.
Distributor ID:	Debian
Description:	Debian GNU/Linux 11 (bullseye)
Release:	11
Codename:	bullseye

lsmod | grep snd
snd_aloop              32768  0
snd_pcm               135168  1 snd_aloop
snd_timer              49152  2 snd_aloop,snd_pcm
snd                   110592  3 snd_timer,snd_aloop,snd_pcm
soundcore              16384  1 snd

- hosts: matrix_servers
  become: true
  tasks:
    - name: Install Debian based dependencies
      block:
      - name: Update apt cache
        apt: update_cache=true cache_valid_time=600
        changed_when: false
        when: ansible_os_family == 'Debian'
      - name: Update all Packages
        apt: 
          upgrade: yes
        when: ansible_os_family == 'Debian'
      - name: Install Generic Kernel with snd-aloop support
        apt:
          name: 'linux-image-amd64'
          state: present
      when: ansible_os_family == 'Debian'
    - name: Change Grub Default Kernel
      ansible.builtin.lineinfile:
        path: /etc/default/grub
        regex: '^GRUB_DEFAULT=[\"0-9><,]+'
        state: present
        line: 'GRUB_DEFAULT="1>2"'
    - name: Update Grub.cfg
      ansible.builtin.command:
        cmd: grub-mkconfig -o /boot/grub/grub.cfg
      changed_when: false
    - name: Setup snd-aloop module modprobe
      block: 
      - name: /etc/modules
        ansible.builtin.lineinfile:
          path: /etc/modules
          regex: '^snd-aloop'
          state: present
          line: 'snd-aloop'
      - name: /etc/modprobe.d/alsa-loopback.conf
        ansible.builtin.copy:
          content: 'options snd-aloop enable=1,1,1,1,1 index=0,1,2,3,4'
          dest: /etc/modprobe.d/alsa-loopback.conf
          mode: '0644'
      - name: Reboot the machine
        reboot:
  vars:
    ansible_python_interpreter: /usr/bin/python3

I am trying to figure out why my record button is not appearing right now.

github-actions · 2024-11-26T02:47:11Z

This PR is stale because it has not been provided with required information or its conflicts have not been fixed over a year. Remove stale label or this will be closed in 30 days. To exempt the PR from being marked as stale again due to inactivity, add "confirmed" label.

pcorace added 3 commits November 28, 2020 16:48

Incluyo la imagen docker de Jibri

30edc0a

Templates and Task for Jibri

c4d4338

actualizo cambios en main y config

826947b

teutat3s reviewed Nov 29, 2020

View reviewed changes

akshaylive added a commit to akshaylive/matrix-docker-ansible-deploy that referenced this pull request Mar 4, 2021

Jibri initial commit

1743d3e

Most of the work is done [here](spantaleev#739).

akshaylive added a commit to akshaylive/matrix-docker-ansible-deploy that referenced this pull request Mar 4, 2021

Jibri initial commit

9f9979e

Most of the work is done [here](spantaleev#739).

akshaylive added a commit to akshaylive/matrix-docker-ansible-deploy that referenced this pull request Mar 4, 2021

Jibri initial commit

ac09066

Most of the work is done [here](spantaleev#739).

pcorace marked this pull request as ready for review March 4, 2021 13:49

hungrymonkey pushed a commit to mederrata/matrix-docker-ansible-deploy that referenced this pull request Aug 3, 2021

Jibri initial commit

e58b214

Most of the work is done [here](spantaleev#739).

hungrymonkey pushed a commit to mederrata/matrix-docker-ansible-deploy that referenced this pull request Aug 3, 2021

Jibri initial commit

edc52d3

Most of the work is done [here](spantaleev#739).

hungrymonkey pushed a commit to mederrata/matrix-docker-ansible-deploy that referenced this pull request Aug 7, 2021

Jibri initial commit

48878f5

Most of the work is done [here](spantaleev#739).

hungrymonkey pushed a commit to mederrata/matrix-docker-ansible-deploy that referenced this pull request Aug 7, 2021

Jibri initial commit

a2b84e3

Most of the work is done [here](spantaleev#739).

hungrymonkey pushed a commit to mederrata/matrix-docker-ansible-deploy that referenced this pull request Aug 22, 2021

Jibri initial commit

f9472e0

Most of the work is done [here](spantaleev#739).

hungrymonkey pushed a commit to mederrata/matrix-docker-ansible-deploy that referenced this pull request Aug 22, 2021

Jibri initial commit

172cf82

Most of the work is done [here](spantaleev#739).

luixxiul added the needs-rebase label Nov 23, 2024

This comment was marked as outdated.

Sign in to view

github-actions bot added the stale label Nov 25, 2024

luixxiul removed the stale label Nov 25, 2024

github-actions bot added the stale label Nov 26, 2024

luixxiul mentioned this pull request Nov 26, 2024

Update .github/workflows/close-stale-issues.yml: edit stale messages and fix any-of-labels #3817

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Jibri work in progress #739

Add Jibri work in progress #739

pcorace commented Nov 29, 2020

spantaleev commented Nov 29, 2020

teutat3s left a comment •

edited

Loading

teutat3s Nov 29, 2020

akshaylive Mar 4, 2021

teutat3s Nov 29, 2020 •

edited

Loading

teutat3s left a comment

teutat3s Nov 29, 2020

teutat3s Nov 29, 2020

teutat3s Nov 29, 2020

pcorace commented Nov 29, 2020

ffuentes commented Jan 31, 2021

akshaylive commented Mar 4, 2021

pcorace commented Mar 4, 2021

akshaylive commented Mar 6, 2021

pcorace commented Mar 6, 2021

hungrymonkey commented Aug 23, 2021

hungrymonkey commented Aug 23, 2021 •

edited

Loading

This comment was marked as outdated.

github-actions bot commented Nov 26, 2024

		// MUST be unic for every instanse
		"nickname": "jibri-instanse-1"

Add Jibri work in progress #739

Are you sure you want to change the base?

Add Jibri work in progress #739

Conversation

pcorace commented Nov 29, 2020

spantaleev commented Nov 29, 2020

teutat3s left a comment • edited Loading

Choose a reason for hiding this comment

teutat3s Nov 29, 2020

Choose a reason for hiding this comment

akshaylive Mar 4, 2021

Choose a reason for hiding this comment

teutat3s Nov 29, 2020 • edited Loading

Choose a reason for hiding this comment

teutat3s left a comment

Choose a reason for hiding this comment

teutat3s Nov 29, 2020

Choose a reason for hiding this comment

teutat3s Nov 29, 2020

Choose a reason for hiding this comment

teutat3s Nov 29, 2020

Choose a reason for hiding this comment

pcorace commented Nov 29, 2020

ffuentes commented Jan 31, 2021

akshaylive commented Mar 4, 2021

pcorace commented Mar 4, 2021

akshaylive commented Mar 6, 2021

pcorace commented Mar 6, 2021

hungrymonkey commented Aug 23, 2021

hungrymonkey commented Aug 23, 2021 • edited Loading

This comment was marked as outdated.

github-actions bot commented Nov 26, 2024

teutat3s left a comment •

edited

Loading

teutat3s Nov 29, 2020 •

edited

Loading

hungrymonkey commented Aug 23, 2021 •

edited

Loading