Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ansible-community/ansible-lint-action with ansible/ansible-lint #3827

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

luixxiul
Copy link
Collaborator

No description provided.

ansible-community/ansible-lint-action was deprecated on Aug 2, 2023, and it recommends to use the current Github action here: https://github.com/marketplace/actions/run-ansible-lint

Signed-off-by: Suguru Hirahara <[email protected]>
@luixxiul luixxiul added the help-wanted Extra attention from the community is needed label Nov 26, 2024
@luixxiul
Copy link
Collaborator Author

luixxiul commented Nov 26, 2024

@spantaleev would you mind fixing the failures which cannot be skipped, as I am not sure how to?

@luixxiul luixxiul marked this pull request as ready for review November 26, 2024 15:32
@spantaleev
Copy link
Owner

I'm not sure if this can be gotten to work that easily.

I've adjusted it to define a requirements_file (requirements.yml), so that roles could be installed. Roles are installed now, as seen here, but they are installed to /home/runner/.ansible/roles, not under roles/galaxy as the playbook expects.

The playbook's justifle and Makefile install into a custom path (roles/galaxy) by passing it as an additional argument to the ansible-galaxy tool. agru seems to default to using roles/galaxy.

We may look for ways to make this Github Action install roles into roles/galaxy. I've tried defining an ANSIBLE_ROLES_PATH environment variable, as discussed here, and it seems like it's taken into account, but roles are now installed into roles, not roles/galaxy. Perhaps additional tweaks are necessary (maybe switching the order of the 2 entries).


Another issue is the lack of "Ansible collection" modules, like community.docker.docker_image as seen here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted Extra attention from the community is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants