Padding was calculated incorrectly #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CK. Full block of padding should be used. Instead no padding was applied.
|
will review and approve! thanks |
|
your suggestion is correct thank you. |
palto42
added a commit
to palto42/AES
that referenced
this pull request
May 7, 2018
Combined proposed fixes of pull requests spaniakos#15 and spaniakos#16 plus the required change of the function `AES::CheckPad(byte* in,int lsize)`. The function `AES::calc_size_n_pad`could be simplified by combining spaniakos#15 and spaniakos#16 and also ` `AES::CheckPad` is simpler because there is always padding added. The definition of `byte arr_pad` in `AES.h` must also be aligned for the extra padding value 0x10.
This was referenced May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case size was multiple of N_BLOCK full block of padding should be used. Instead no padding was applied. Issue is fixed now.