Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly categorized Ecto spans #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrz
Copy link

@mrz mrz commented May 30, 2022

I use Spandex to send traces to Datadog in two different Elixir projects, using spandex_phoenix and spandex_ecto in conjunction with spandex_datadog. I've noticed that there are some database spans that are incorrectly categorized as Web spans in the spans view, and I've traced the issue back to how spandex_ecto creates the spans. You can see the problem in these screenshots:

screenshot-2022-05-30-10:25:17

screenshot-2022-05-30-10:26:22

As you can see, the first screenshot is showing the Web spans for a trace in Datadog with some Ecto operations. Those are the queue, run_query and decode spans. Switching to the DB spans shows the same operation, but this time it's the query span.

This PR aims to correct this small inconvenience.

@sourcelevel-bot
Copy link

Hello, @mrz! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant