Fix incorrectly categorized Ecto spans #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use Spandex to send traces to Datadog in two different Elixir projects, using
spandex_phoenix
andspandex_ecto
in conjunction withspandex_datadog
. I've noticed that there are some database spans that are incorrectly categorized as Web spans in the spans view, and I've traced the issue back to howspandex_ecto
creates the spans. You can see the problem in these screenshots:As you can see, the first screenshot is showing the Web spans for a trace in Datadog with some Ecto operations. Those are the
queue
,run_query
anddecode
spans. Switching to the DB spans shows the same operation, but this time it's thequery
span.This PR aims to correct this small inconvenience.