Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pstat overplot #31

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Conversation

stscicrawford
Copy link
Contributor

Add a parameter to allow for pstat plots to be overplotted on the previous call to pstat.

@stscicrawford
Copy link
Contributor Author

Fixes #27

@stscicrawford stscicrawford requested a review from SaOgaz October 11, 2018 17:18
@mackjenn
Copy link
Contributor

mackjenn commented Jan 8, 2019

@SaOgaz This functionality would be really helpful for WFC3 users to diagnose Earth limb contamination. Looks like failures are with numpy_version=1.9 ?? Any idea how to solve this?

@sosey
Copy link
Member

sosey commented Jan 8, 2019

The testing files need to be updated in either case, they are hella old....I dont think we should be testing below 1.11 at this point

@stscicrawford
Copy link
Contributor Author

I think @SaOgaz had on her list to update the testing files. As the tests that are failing are the older ones, I'm going to go ahead and merge this.

@stscicrawford stscicrawford merged commit 6a11234 into spacetelescope:master Jan 14, 2019
@pllim
Copy link
Contributor

pllim commented Jan 17, 2019

AFAIK @SaOgaz has never been involved in this package. And personally I still don't know who is the maintainer now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants