add trending plot function "show_wfs_around_obs" #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #705 +/- ##
===========================================
- Coverage 55.94% 55.42% -0.53%
===========================================
Files 15 15
Lines 6281 6342 +61
===========================================
+ Hits 3514 3515 +1
- Misses 2767 2827 +60
☔ View full report in Codecov by Sentry. |
|
Great addition. Again a test with a NIRCam LW. Everything looks good. |
|
Looking at your example, why is the WFE the same before/after if there was a big tilt event in between? The top panel is the WFE, right? |
|
Top panel actually just a horizontal timeline; there is no significance to any vertical axis there. Just separation in time horizontally. It could be changed to be an RMS, in some future PR, but I made this top panel just showing time on one axis and nothing else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR, adds one function "show_wfs_around_obs" that displays the WFS before and after a given science observation, and the spacing in time between those observations.
Low priority addition, not critical, but I wrote this function a while ago and wanted to get it into a PR.