Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test matrix #207

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Update test matrix #207

merged 2 commits into from
Sep 10, 2024

Conversation

mcara
Copy link
Member

@mcara mcara commented Sep 9, 2024

Updates the test matrix and also fixes an incompatibility with upcoming changes in astropy 7.0 - see astropy/astropy#16673 (comment)

@mcara mcara self-assigned this Sep 9, 2024
@mcara mcara requested a review from a team as a code owner September 9, 2024 13:23
@mcara mcara force-pushed the update-test-matrix branch from 9fd9093 to 0abb2e9 Compare September 9, 2024 13:25
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.63%. Comparing base (6044438) to head (7c63fec).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
tweakwcs/linearfit.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   93.73%   93.63%   -0.10%     
==========================================
  Files          11       11              
  Lines        2010     2011       +1     
==========================================
- Hits         1884     1883       -1     
- Misses        126      128       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcara mcara requested a review from zacharyburnett September 9, 2024 13:28
@zacharyburnett
Copy link
Collaborator

this looks good, but do we need all of this specificity in numpy versions? Would it serve the same purpose to have one test for numpy 1.*, one for 2.*, and one for a nightly build?

@mcara mcara force-pushed the update-test-matrix branch 2 times, most recently from ceef943 to 337a003 Compare September 10, 2024 01:00
@mcara mcara force-pushed the update-test-matrix branch from 337a003 to 7c63fec Compare September 10, 2024 01:18
@mcara mcara merged commit 0b98f50 into spacetelescope:main Sep 10, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants