-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch RuntimeError and raise custom exception for xyxymatch error #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
force-pushed
the
custom_exception
branch
from
May 16, 2024 16:37
687d8da
to
3bf730b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
- Coverage 93.77% 93.74% -0.03%
==========================================
Files 11 11
Lines 1992 1999 +7
==========================================
+ Hits 1868 1874 +6
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
8 tasks
braingram
force-pushed
the
custom_exception
branch
from
May 16, 2024 16:46
3bf730b
to
b2d2723
Compare
mcara
reviewed
May 17, 2024
Thanks for the review and suggestions. I included them in the most recent commits. |
mcara
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR catches the
RuntimeError
raised byxyxymatch
when multiple reference sources match a single source and raises a custom exception.This change is motivated by the error handling code in jwst and romancal which inspect the error message and can be simplified once the changes in this PR are released.
See the below linked issue for details and why this change is being made in tweakwcs instead of
xyxymatch
Closes spacetelescope/stsci.stimage#33