Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zenodo badge #189

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add Zenodo badge #189

merged 1 commit into from
Nov 30, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Nov 29, 2023

Looks like you have a DOI via release webhook. You should advertise it. cc @rosteen

p.s. Are you still using Azure Pipelines? Why not Actions?

@pllim pllim added the documentation Documentation update or correction label Nov 29, 2023
@pllim pllim requested a review from a team as a code owner November 29, 2023 19:20
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c98e703) 94.38% compared to head (9f8321e) 94.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   94.38%   94.38%           
=======================================
  Files          11       11           
  Lines        1941     1941           
  Branches      295      295           
=======================================
  Hits         1832     1832           
  Misses         91       91           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcara
Copy link
Member

mcara commented Nov 29, 2023

Are you still using Azure Pipelines? Why not Actions?

It is to not forget about @jhunkeler contribution to this package

@pllim
Copy link
Contributor Author

pllim commented Nov 29, 2023

I think the setuptools stuff needs updating because your sdist build is failing but that is not related to this PR.

from setuptools import setup, find_packages
ModuleNotFoundError: No module named 'setuptools'

@mcara
Copy link
Member

mcara commented Nov 29, 2023

I think the setuptools stuff needs updating because your sdist build is failing but that is not related to this PR.

from setuptools import setup, find_packages
ModuleNotFoundError: No module named 'setuptools'

Probably will be solved by #188 which was awaiting a new gwcs release (which, I heard, happened today). So, just patience, please. I am looking into possible modifications to that PR.

@mcara
Copy link
Member

mcara commented Nov 30, 2023

setuptools issue is strange as no other PR was merged since c98e703 and then tests were passing.

@mcara
Copy link
Member

mcara commented Nov 30, 2023

I knew if I mention @jhunkeler three times...

@pllim
Copy link
Contributor Author

pllim commented Nov 30, 2023

Python has changed stuff too, so maybe your code just have to modernize the packaging.

@mcara
Copy link
Member

mcara commented Nov 30, 2023

Python has changed stuff too, so maybe your code just have to modernize the packaging.

working on it

@pllim
Copy link
Contributor Author

pllim commented Nov 30, 2023

I think your incantation worked, Mihai. See #190

@mcara
Copy link
Member

mcara commented Nov 30, 2023

Please rebase

@pllim pllim merged commit 11d28e9 into master Nov 30, 2023
14 of 16 checks passed
@pllim pllim deleted the pllim-patch-1 branch November 30, 2023 15:28
@pllim
Copy link
Contributor Author

pllim commented Nov 30, 2023

This is just a PR to add badge, I don't think CI is even needed, so I just merged it. Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation update or correction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants