Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise ImportError for missing 'hstcal' binaries #168

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Raise ImportError for missing 'hstcal' binaries #168

wants to merge 2 commits into from

Conversation

sean-lockwood
Copy link
Member

@sean-lockwood sean-lockwood commented Dec 4, 2024 •
edited
Loading

Check the $PATH for hstcal binaries (cs0.e) when importing stistools. Raise an ImportError if this is not found. Skips this check on RTD.

@sean-lockwood
Check the $PATH for hstcal binaries (cs0.e) when importing stistools.…
4974a72 
… Raise an ImportError if this is not found. This should hopefully eliminate half of our help calls.
@sean-lockwood
Copy link
Member Author

@stscirij -
Any problem raising an error on import like this?

@stscirij
Copy link
Contributor

stscirij commented Dec 4, 2024

I think this seems reasonable, although it probably won't work under Windows :)

@sean-lockwood
Copy link
Member Author

Looks like hstcal doesn't support Windows anyway:

image

@sean-lockwood
Copy link
Member Author

Some of the stistools routines don't require an hstcal binary. Perhaps we should more precisely where to put this check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sean-lockwood @stscirij