JP-3697: Jump Step Refactor #330
Closed
+2,201
−1,446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de management easier. Adding initial creation of JumpData class. Adding default values to class instantiation. Updating tests to work with the new interface. Updating all tests. Still need to clean up code and add docstrings. Removing unneeded paramter. Removing unneeded parameters. Refactoring code to use the JumpData class. Adding parameters to JumpData. Updating jump CI tests to match the refactoring using the JumpData. Updating find_faint_extended function to use the RampData class. Updating jump tests to conform with refactor. Removing unneeded comments. Refactored the multiprocessing and two point difference. Regactored the multiprocessing. Refactored out dqflags parameter and the multiprocessing function. Updating the TwoPointParams class to remove the dqflags parameter. Refactoring median calculations of first differences. Expanding comments and identifying areas for refactor. Refactoring find_faint_extended. Refactoring find_faing_extended. Refactoring find_crs. Adding print information for a JumpData instance. Prepping for rebase.
…the jump step parameters because it is not used.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
===========================================
+ Coverage 29.57% 84.54% +54.96%
===========================================
Files 36 49 +13
Lines 7949 9321 +1372
===========================================
+ Hits 2351 7880 +5529
+ Misses 5598 1441 -4157 ☔ View full report in Codecov by Sentry. |
|
I need to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3697
Closes #
This PR refactors STCAL focusing on readability, memory consumption, and limiting scope of variables. This refactor reduced jump step memory reduction. The resident size of memory is reduced by more than 2GB, with the memory consumption spike due to
numpy.nanmediancompletely eliminated, and the heap size reduced by 1GB.The interface has been simplified with classes. Large functions have been logically broken into smaller functions for readability and scope limiting. Code duplications have been eliminated. Dead code and duplicated variable definitions have been eliminated.
The
twopoint_difference.pystill needs to be refactored.All CI tests pass.
All CI tests in the corresponding JWST PR pass, as do all '-k jump' regression tests.
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)"git+https://github.com/<fork>/stcal@<branch>")jwstregression testromancalregression testnews fragment change types...
changes/<PR#>.apichange.rst: change to public APIchanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.general.rst: infrastructure or miscellaneous change