Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use newest releases of stcal and stpipe #1573

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use newest releases of stcal and stpipe #1573

wants to merge 1 commit into from

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jan 2, 2025 •
edited
Loading

stcal 1.11.0 and stpipe 0.8.0 were released. This PR updates pyproject.toml to use the new releases (instead of development versions).

Regtests running: https://github.com/spacetelescope/RegressionTests/actions/runs/12587972475
Some failures are expected as some tests are failing on main: https://github.com/spacetelescope/RegressionTests/actions/runs/12575662194

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.patch_match.rst

steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jan 2, 2025
@braingram braingram marked this pull request as ready for review January 2, 2025 20:22
@braingram braingram requested a review from a team as a code owner January 2, 2025 20:22
@braingram
Copy link
Collaborator Author

py3-devdeps-webbpsf and py3-stdevdeps-webbpsf fail with this PR and are failing on main:
https://github.com/spacetelescope/romancal/actions/runs/12436434544/job/34724294880
https://github.com/spacetelescope/romancal/actions/runs/12436434544/job/34724294631
as stcal does not support python 3.13 (the py3 version) see spacetelescope/stcal#300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file no-changelog-entry-needed run devdeps tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@braingram