Updates from RSP test feedback to working_with_asdf and measuring_galaxy_shapes
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not yet addressed the comments regarding pretty-printing ADSF contents as they require extra code that might make the tutorials a bit more clunky and harder to follow. |
tddesjardins
approved these changes
Sep 17, 2024
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "By default the PSF is generated for SCA 01 at `(x, y)` 2048, 2048 in the detector coordinate system. These can be confirmed and modified via the `nc.detector` and `nc.detector_position` methods." |
There was a problem hiding this comment.
Are you sure it's the detector coordinate system? I thought webbpsf used the science orientation (just confirmed with Charles).
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "We have limited the number of rows printed to 30, but if you want to see all rows, you can change that number to your liking or to `None` in order to see all nodes." |
There was a problem hiding this comment.
Today I learned about using a None for this. Nice.
tddesjardins
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Oops, hit the wrong button. @fjaviersanchez can you change the coordinate system info in the measuring galaxy shapes notebook? Other than that I approve!
tddesjardins
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address the comments from the RSP testing session for the
working_with_asdfandmeasuring_galaxy_shapesnotebooks.