Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min Python to 3.11 per SPEC 0 #432

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

WilliamJamieson
Copy link
Collaborator

This PR bumps min python to 3.11 per SPEC 0. astropy 7 has already made this bump.

Tasks

  • Update or add relevant roman_datamodels tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner November 26, 2024 16:47
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (087a60d) to head (4f970eb).
Report is 86 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   97.56%   97.33%   -0.23%     
==========================================
  Files          30       37       +7     
  Lines        2788     3307     +519     
==========================================
+ Hits         2720     3219     +499     
- Misses         68       88      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@WilliamJamieson WilliamJamieson force-pushed the mnt/bump_to_py311 branch 2 times, most recently from 2e46c41 to 4a517e0 Compare December 2, 2024 16:46
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus one question

pyproject.toml Show resolved Hide resolved
@braingram braingram enabled auto-merge (squash) December 3, 2024 21:10
@braingram braingram merged commit 313bedd into spacetelescope:main Dec 3, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants