Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix DrizzlePac align_multiple_visits #80

Open
pllim opened this issue Mar 20, 2019 · 3 comments
Open

TST: Fix DrizzlePac align_multiple_visits #80

pllim opened this issue Mar 20, 2019 · 3 comments
Assignees
Labels
bug Something isn't working Drizzlepac

Comments

@pllim
Copy link
Contributor

pllim commented Mar 20, 2019

Currently, CI is failing because align_multiple_visits notebook uses glob to provide inputs for TweakReg. Unfortunately, glob order can be arbitrary and not well suited for the purpose of running it in a CI. The solution is to provide a deterministic list of input files via .lis file.

Related issues: #77, #78

@pllim pllim added bug Something isn't working Drizzlepac labels Mar 20, 2019
@pllim
Copy link
Contributor Author

pllim commented Mar 20, 2019

You would also need to un-exclude the notebook so CI would pick it up again. I excluded it in 18ba024 .

@pllim
Copy link
Contributor Author

pllim commented Mar 25, 2019

align_mosaic might have the same problem, as it failed in an unrelated PR in #88.

https://spacetelescope.github.io/notebooks/notebooks/DrizzlePac/align_mosaics/align_mosaics.html

@catherine-martlin
Copy link
Contributor

See #89 for the fix - currently WIP but hopefully this test will solve the issue we were running into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Drizzlepac
Projects
None yet
Development

No branches or pull requests

2 participants