Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: CircleCI to run subsequent notebooks even if previous one fails #83

Closed
pllim opened this issue Mar 21, 2019 · 1 comment · Fixed by #96
Closed

TST: CircleCI to run subsequent notebooks even if previous one fails #83

pllim opened this issue Mar 21, 2019 · 1 comment · Fixed by #96
Assignees

Comments

@pllim
Copy link
Contributor

pllim commented Mar 21, 2019

When CircleCI is enabled for a pull request, a significant of the failures stemmed from other unrelated notebooks (e.g., #80 and timeouts from MAST queries). But really the author is interested to see if the new notebook added in the PR can pass CI. I propose CircleCI does not just stop when it encounters the first failure, but to keep going until the end, and then report what failed and what didn't.

OR CircleCI should just run that one notebook without author having to manually exclude the rest. But that also means if the PR messes up requirements for the other notebooks, we won't know.

@astro-josh
Copy link
Contributor

astro-josh commented Mar 21, 2019

@pllim This has to be implemented in nbpages, these are waiting review there:
nbpages PR for only checking changed notebooks
this also contains logic to detect 'global changes' or changes that would affect all notebooks triggering a build of all notebooks. Also flags any notebooks as 'changed' if any file in that notebook directory changes, i.e. requirements, etc.
nbpages PR for report generation (if a notebook fails, continues but logs it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants