TST: See if percentile is breaking devdeps #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kecnry
reviewed
Mar 12, 2024
Co-authored-by: Kyle Conroy <[email protected]>
kecnry
reviewed
Mar 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 93.92% 93.81% -0.12%
==========================================
Files 37 37
Lines 1598 1601 +3
==========================================
+ Hits 1501 1502 +1
- Misses 97 99 +2 ☔ View full report in Codecov by Sentry. |
|
hmmm, can you cherrypick kecnry#5 here (which will break all other CI runs, but hopefully let the dev one run)? Or I can just bite the bullet and add logic to support both at once.... but since lcviz currently pins to a minor version of jdaviz that hasn't really been necessary except for this testing headache. |
|
I was hoping I don't have to do clone this repo locally... I guess I will have to now... |
|
Okie dokie... Gonna branch from #68 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to understand failures in #93