Viewer creator in app toolbar

[kecnry]

NOTE: this should be tested with jdaviz 3.8.x since this does not include updates for jdaviz 3.9 covered in #68.

This adds a viewer creator dropdown in the app-level toolbar which can create viewers, including phase viewers attached to a specific ephemeris.

Screen.Recording.2024-03-08.at.2.05.20.PM.mov

The current behavior is to first check for an existing viewer with a matching label and if it exists, clone the existing viewer (keeping data visibilities and plot options, etc), and otherwise create a new viewer.

TODO:

• testing with renaming ephemeris
• either here or follow-up: move ephemeris logic into viewer metadata instead of relying on viewer label
• decide whether to allow all time viewers to be closed (and if so, test layer-visibility logic assumptions for new phase viewers)
• upstream support for automatically opening data menu on blank viewer: Open data menu on new blank viewer jdaviz#2742

Once merged:

• rebase the 3.9-updates and TPF feature branch on top of main and add support for image viewers (might require fixing clone support first)
• design and create ticket for what to show when no viewers exist?

The styling will also be improved by upstream spacetelescope/jdaviz#2743

[codecov]

Codecov Report

Attention: Patch coverage is 93.07692% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 94.05%. Comparing base (db3548d) to head (f699c82).

Files	Patch %	Lines
lcviz/plugins/ephemeris/ephemeris.py	87.17%	5 Missing ⚠️
lcviz/helper.py	95.00%	1 Missing ⚠️
lcviz/parsers.py	80.00%	1 Missing ⚠️
lcviz/plugins/viewer_creator/viewer_creator.py	96.55%	1 Missing ⚠️
lcviz/viewers.py	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   94.18%   94.05%   -0.14%     
==========================================
  Files          35       37       +2     
  Lines        1548     1598      +50     
==========================================
+ Hits         1458     1503      +45     
- Misses         90       95       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rosteen]

Functionality seems to work but I think the button really needs a tooltip - is there some difficulty with adding one to a downstream (from Jdaviz) component like this?

[kecnry]

Yes, this will be covered by spacetelescope/jdaviz#2743 and spacetelescope/jdaviz#2744 upstream and pulled in here by #68.

[rosteen]

Yes, this will be covered by spacetelescope/jdaviz#2743 and spacetelescope/jdaviz#2744 upstream and pulled in here by #68.

Got it, thanks - I figured it wasn't trivial to insert something into out tooltip registry as-is. In that case I think this looks good to get in, I worry slightly about the number of things in the duplication menu getting out of hand, but also think it's very unlikely someone would create that many viewers.