fix creating phase-viewer when TPF is loaded #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature-tpf #86 +/- ##
===============================================
- Coverage 93.05% 93.00% -0.05%
===============================================
Files 35 35
Lines 1742 1744 +2
===============================================
+ Hits 1621 1622 +1
- Misses 121 122 +1 ☔ View full report in Codecov by Sentry. |
kecnry
added a commit
that referenced
this pull request
Apr 5, 2024
* Adding TPF translator and parser (#75) * TPF viewer (#81) * make use of upstream refactor to override indices in lcviz (#83) * fix creating phase-viewer when TPF is loaded (#86) * Time Selector (adapted version of cubeviz's slice) plugin (#85) * enable clone viewer for image/TPF viewer (#101) --------- Co-authored-by: Brett M. Morris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a TPF was loaded before the phase-viewer was created, then the TPF data was loaded into the phase-viewer, resulting in a traceback. Now when creating a phase-viewer, only 1D data are loaded into the viewer (with visibilities still defaulted based on the visibilities in the time viewer).