Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make check for n_bins more robust/performant #80

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jan 10, 2024

tests were occasionally failing because they relied on an exception in the live-update which sometimes did not trigger in time.

tests were occasionally failing because they relied on an exception in the live-update which sometimes did not trigger in time.
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (a4eaea7) 95.04% compared to head (8503d3f) 94.23%.
Report is 2 commits behind head on main.

Files Patch % Lines
lcviz/components/components.py 92.64% 5 Missing ⚠️
lcviz/plugins/flatten/flatten.py 81.48% 5 Missing ⚠️
lcviz/tools.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   95.04%   94.23%   -0.81%     
==========================================
  Files          32       36       +4     
  Lines        1393     1545     +152     
==========================================
+ Hits         1324     1456     +132     
- Misses         69       89      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry marked this pull request as ready for review January 10, 2024 13:38
@kecnry kecnry merged commit cb0e3cd into spacetelescope:main Jan 10, 2024
9 of 11 checks passed
@kecnry kecnry deleted the bin-enabled-more-robust branch January 10, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant