API hints #133
Merged
API hints #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
- Coverage 93.92% 91.20% -2.73%
==========================================
Files 37 41 +4
Lines 1598 2149 +551
==========================================
+ Hits 1501 1960 +459
- Misses 97 189 +92 ☔ View full report in Codecov by Sentry. |
kecnry
added
the
waiting-on-jdaviz-release
bmorris3
approved these changes
Aug 21, 2024
Comment on lines
+242
to
+250
| {{ api_hints_enabled ? | ||
| 'plg.query_for_ephemeris()' | ||
| : | ||
| 'Query' | ||
| }} |
There was a problem hiding this comment.
You got the query_for_ephemeris method for this portion of the plugin, but not the name/RA/Dec/radius fields above:
There was a problem hiding this comment.
yep, you didn't expose those to the API in #127 😝 Do you want me to add them here?
There was a problem hiding this comment.
these are now exposed in the API and hints added in this PR.
kecnry
removed
the
waiting-on-jdaviz-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement API hints across all plugins.
Requires spacetelescope/jdaviz#3159 to be merged and included in the 4.0 release of jdaviz.Waiting for:
jdaviz 4.0