strip filepath from filename entry in metadata #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* originally populated by lightkurve
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 93.92% 91.16% -2.77%
==========================================
Files 37 41 +4
Lines 1598 2060 +462
==========================================
+ Hits 1501 1878 +377
- Misses 97 182 +85 ☔ View full report in Codecov by Sentry. |
bmorris3
approved these changes
Jul 13, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/lcviz
that referenced
this pull request
Jul 15, 2024
kecnry
added a commit
to meeseeksmachine/lcviz
that referenced
this pull request
Jul 15, 2024
kecnry
added a commit
that referenced
this pull request
Jul 15, 2024
Co-authored-by: Kyle Conroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lightkurve sets the FILENAME entry in the metadata (even if not in the original fits header), resulting in lcviz showing the full filepath in the metadata plugin. This PR replaces that with the basename to avoid exposing full filepaths (on the MAST embedded version, for example).