Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdaviz 4.0 updates #121

Merged
merged 2 commits into from
Oct 17, 2024
Merged

jdaviz 4.0 updates #121

merged 2 commits into from
Oct 17, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jun 26, 2024

  • update pin once jdaviz is released

Should close #116 (as jdaviz 4.0 no longer requires voila)

Waiting for: jdaviz 4.0

@kecnry kecnry added the waiting-on-jdaviz-release PR requires a release from jdaviz before updating the pin label Jun 26, 2024
@kecnry kecnry added this to the 0.5.0 milestone Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.20%. Comparing base (7b78df5) to head (3a7796a).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   93.92%   91.20%   -2.73%     
==========================================
  Files          37       41       +4     
  Lines        1598     2148     +550     
==========================================
+ Hits         1501     1959     +458     
- Misses         97      189      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry removed the waiting-on-jdaviz-release PR requires a release from jdaviz before updating the pin label Oct 17, 2024
@kecnry kecnry marked this pull request as ready for review October 17, 2024 16:06
@kecnry kecnry merged commit f94637b into spacetelescope:main Oct 17, 2024
13 of 14 checks passed
@kecnry kecnry deleted the jdaviz-4.0 branch October 17, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to import lcviz and problems with visualising the data-points on the graph
1 participant