Skip to content

Commit

Permalink
milestone/changelog checkers (#112)
Browse files Browse the repository at this point in the history
adopted from jdaviz

Co-authored-by: P. L. Lim <[email protected]>
  • Loading branch information
kecnry and pllim authored Apr 19, 2024
1 parent 0ef6d77 commit cd414de
Show file tree
Hide file tree
Showing 2 changed files with 54 additions and 0 deletions.
20 changes: 20 additions & 0 deletions .github/workflows/check_changelog.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: Check PR change log

on:
pull_request:
types: [opened, synchronize, labeled, unlabeled]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
changelog_checker:
name: Check if change log entry is correct
runs-on: ubuntu-latest
steps:
- name: Check change log entry
uses: scientific-python/[email protected]
env:
CHANGELOG_FILENAME: CHANGES.rst
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
34 changes: 34 additions & 0 deletions .github/workflows/check_milestone.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Check PR milestone

on:
# So it cannot be skipped.
pull_request_target:
types: [opened, synchronize, milestoned, demilestoned]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: read

jobs:
# https://stackoverflow.com/questions/69434370/how-can-i-get-the-latest-pr-data-specifically-milestones-when-running-yaml-jobs
milestone_checker:
runs-on: ubuntu-latest
steps:
- uses: actions/github-script@v7
if: github.repository == 'spacetelescope/lcviz'
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const { data } = await github.request("GET /repos/{owner}/{repo}/pulls/{pr}", {
owner: context.repo.owner,
repo: context.repo.repo,
pr: context.payload.pull_request.number
});
if (data.milestone) {
core.info(`This pull request has a milestone set: ${data.milestone.title}`);
} else {
core.setFailed(`A maintainer needs to set the milestone for this pull request.`);
}

0 comments on commit cd414de

Please sign in to comment.