more robust handling that still accepts unitless empty string

spacetelescope · Jun 27, 2024 · b547ad6 · b547ad6
1 parent 96dd39c
commit b547ad6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -6,7 +6,7 @@
 0.4.1 (unreleased)
 ------------------
 
-* Fixes CDIPS support by handling units stored as empty strings. [#122]
+* Fixes CDIPS support by handling columns filled with strings with empty units. [#122]
 
 0.4.0 (06-11-2024)
 ------------------

diff --git a/lcviz/utils.py b/lcviz/utils.py
@@ -281,8 +281,14 @@ def to_object(self, data_or_subset):
 
             if len(values) and isinstance(values[0], Time):
                 values = Time(values.base)
-            elif hasattr(component, 'units') and component.units not in ("None", ""):
-                values = u.Quantity(values, component.units)
+            elif hasattr(component, 'units') and component.units != "None":
+                try:
+                    values = u.Quantity(values, component.units)
+                except TypeError:
+                    if component.units != "":
+                        raise
+                    # values could have been an array of strings with units ""
+                    values = values
 
             if component_id.label not in names:
                 columns.append(values)