-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up regtests by reorganizing test_nirspec_ifu_spec3 #8811
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8811 +/- ##
=======================================
Coverage 61.86% 61.86%
=======================================
Files 377 377
Lines 38911 38911
=======================================
Hits 24071 24071
Misses 14840 14840 ☔ View full report in Codecov by Sentry. |
260a8b9
to
b7bc19c
Compare
b7bc19c
to
26f7cf9
Compare
26f7cf9
to
54d84c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I've asked @jemorrison to take a quick look too, since she added the pixel replace test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me
This is a minor reorganization of tests in test_nirspec_ifu_spec3 to more efficiently run them in parallel.
This reduces regtests runtime by about 8 minutes.
jwst/regtest/test_nirspec_ifu_spec3.py contains 2 of the slower regtests since the regtests run in parallel scoped by module these 2 tests end up in the same scope given to 1 worker. This worker then spends over 2 hours on those 2 tests (run serially). This PR splits jwst/regtest/test_nirspec_ifu_spec3.py putting the 2 slow fixtures in different files/modules so they can be run on different workers.
Ideally we'd start the slowest tests first so they could toil away while other workers run other tests. If we instead start them later in the test run our overall run will likely end up taking as we wait for the slow test to finish. However this is currently not possible with pytest-xdist (see pytest-dev/pytest-xdist#778).
With this PR regtests ran in 1hr 8 minutes: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1745/ (with only unrelated failures).
Tasks
Build 11.3
(use the latest build if not sure)CHANGES.rst
within the relevant release section (otherwise add theno-changelog-entry-needed
label to this PR)docs/
pageokify_regtests
to update the truth files