Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch okify to GitHub Actions #8762

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

melanieclarke
Copy link
Collaborator

Update the okify script to look for regression test artifacts from GitHub Actions instead of Jenkins

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@melanieclarke
Copy link
Collaborator Author

@tapastro - based on similar changes for romancal, I think this is what's needed to update our okify script when we're ready to move over to GitHub Actions.

I tested by starting an okify run and it found the artifacts appropriately, but didn't try actually okifying anything.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.80%. Comparing base (b01dadd) to head (eb5f0ec).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
jwst/scripts/okify_regtests.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8762   +/-   ##
=======================================
  Coverage   61.79%   61.80%           
=======================================
  Files         377      377           
  Lines       38827    38824    -3     
=======================================
  Hits        23994    23994           
+ Misses      14833    14830    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett
Copy link
Collaborator

this raises the question; should we move the okify script to a common upstream between jwst and romancal, so that underlying infrastructure changes are easier to make?

@melanieclarke
Copy link
Collaborator Author

There are currently some other differences between the two scripts, but we could probably come to an agreement on which version is preferable. I'm all in favor of de-duplicating the code.

@tapastro tapastro marked this pull request as ready for review October 16, 2024 20:06
@tapastro tapastro requested a review from a team as a code owner October 16, 2024 20:06
Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, if the devs are willing to switch to GitHub Actions regression tests as canonical

@zacharyburnett
Copy link
Collaborator

we'll look into consolidating okify_regtests later

@tapastro tapastro merged commit ae78da2 into spacetelescope:main Oct 17, 2024
30 of 31 checks passed
@melanieclarke melanieclarke added this to the Build 11.2 milestone Oct 17, 2024
@melanieclarke melanieclarke deleted the update_okify branch October 17, 2024 15:03
hayescr pushed a commit to hayescr/jwst that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants