-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch okify to GitHub Actions #8762
Conversation
@tapastro - based on similar changes for romancal, I think this is what's needed to update our okify script when we're ready to move over to GitHub Actions. I tested by starting an okify run and it found the artifacts appropriately, but didn't try actually okifying anything. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8762 +/- ##
=======================================
Coverage 61.79% 61.80%
=======================================
Files 377 377
Lines 38827 38824 -3
=======================================
Hits 23994 23994
+ Misses 14833 14830 -3 ☔ View full report in Codecov by Sentry. |
this raises the question; should we move the |
There are currently some other differences between the two scripts, but we could probably come to an agreement on which version is preferable. I'm all in favor of de-duplicating the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me, if the devs are willing to switch to GitHub Actions regression tests as canonical
we'll look into consolidating |
Co-authored-by: Tyler Pauly <[email protected]>
Update the okify script to look for regression test artifacts from GitHub Actions instead of Jenkins
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
added entry inCHANGES.rst
within the relevant release sectionupdated or added relevant testsupdated relevant documentationran regression tests, post a link to the Jenkins job below.How to run regression tests on a PR
Make sure the JIRA ticket is resolved properly