Set DQ of ref pixels to DO_NOT_USE after refpix correction #7017
+72
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7015
This PR addresses the current fragility of how reference pixels are set to DO_NOT_USE in
calwebb_detector1
. Currently they rely on the GAIN reference file having zeros in the reference pixel locations, and thenramp_fitting
sets those pixels to DO_NOT_USE in the science data DQ.This PR sets the DQ of reference pixels to DO_NOT_USE at the end of the
refpix
step. It does require thatDQInitStep
label these properly as REFERENCE_PIXELS, but this seems to be the case currently for the currently selected MASK reference files for all instruments.Is this the best way to do this? Thoughts?
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR