-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: Fix EDB download button #971
base: develop
Are you sure you want to change the base?
Conversation
Hello @bhilbert4, Thank you for updating !
Comment last updated at 2022-07-06 15:16:33 UTC |
This now allows me to download EDB search results. Looking at the changes though, I'm not sure why it wasn't working before. All I really did was change the variable name and updated the name of the file to save into. |
I should say that this worked for me locally. Probably still a good idea to test on one of the servers. |
Switching back to the develop branch and re-testing (locally), I'm now able to download the file. Very confusing. But I've confirmed that the develop branch on the servers fails to download the file. |
Testing on the test server: The csv file is being saved in the expected location. So the issue must be that when the download button is pressed, it's looking in the wrong place for the file? |
This PR fixes the Download Data button on the EDB page. I've also updated the name of the file to include the mnemonic name and start/end dates, rather than being generic.