Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Fix EDB download button #971

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

bhilbert4
Copy link
Collaborator

This PR fixes the Download Data button on the EDB page. I've also updated the name of the file to include the mnemonic name and start/end dates, rather than being generic.

@pep8speaks
Copy link

pep8speaks commented Jul 6, 2022

Hello @bhilbert4, Thank you for updating !

Line 52:34: E126 continuation line over-indented for hanging indent
Line 74:1: E402 module level import not at top of file
Line 75:1: E402 module level import not at top of file
Line 214:64: E226 missing whitespace around arithmetic operator
Line 974:17: W503 line break before binary operator
Line 975:17: W503 line break before binary operator
Line 976:17: W503 line break before binary operator
Line 977:17: W503 line break before binary operator
Line 1327:9: E722 do not use bare 'except'

Comment last updated at 2022-07-06 15:16:33 UTC

@bhilbert4
Copy link
Collaborator Author

This now allows me to download EDB search results. Looking at the changes though, I'm not sure why it wasn't working before. All I really did was change the variable name and updated the name of the file to save into.

@bhilbert4
Copy link
Collaborator Author

I should say that this worked for me locally. Probably still a good idea to test on one of the servers.

@bhilbert4
Copy link
Collaborator Author

Switching back to the develop branch and re-testing (locally), I'm now able to download the file. Very confusing. But I've confirmed that the develop branch on the servers fails to download the file.

@bhilbert4
Copy link
Collaborator Author

Testing on the test server: The csv file is being saved in the expected location. So the issue must be that when the download button is pressed, it's looking in the wrong place for the file?

@bhilbert4 bhilbert4 self-assigned this Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants