Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: source_id is lowercase in Gaia output #3395

Open
wants to merge 1 commit into
base: v4.1.x
Choose a base branch
from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jan 16, 2025

Description

This pull request is to make the CI green again. No idea why it is failing in the first place.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added bug Something isn't working testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Jan 16, 2025
@pllim pllim added this to the 4.1.1 milestone Jan 16, 2025
@github-actions github-actions bot added imviz plugin Label for plugins common to multiple configurations labels Jan 16, 2025
@kecnry
Copy link
Member

kecnry commented Jan 16, 2025

but not on main? 🤔 Should we try both versions? Something like row.get('source_id', row.get('SOURCE_ID'))?

@pllim
Copy link
Contributor Author

pllim commented Jan 16, 2025

Oh wait... looks like it is failing on main too... 🤯

https://github.com/spacetelescope/jdaviz/actions/runs/12814466573/job/35730941003

@pllim
Copy link
Contributor Author

pllim commented Jan 16, 2025

Should we try both versions?

That would violate the Python case-sensitivity rule. Catalogs do not necessarily follow FITS standards.

@pllim pllim changed the base branch from v4.1.x to main January 16, 2025 18:44
@pllim pllim changed the base branch from main to v4.1.x January 16, 2025 18:45
@pllim
Copy link
Contributor Author

pllim commented Jan 16, 2025

Well, I can always open a "forward port" PR once we hash out the diff here. I don't want to be updating 2 branches with the same patch at the same time.

@pllim pllim marked this pull request as ready for review January 16, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working imviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations testing trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants