-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raise error for sidecar or popout when not supported #3309
base: main
Are you sure you want to change the base?
Conversation
@@ -126,6 +127,8 @@ def show_widget(widget, loc, title): # pragma: no cover | |||
display(widget) | |||
|
|||
elif loc.startswith('sidecar'): | |||
if not get_kernel_id(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariobuikhuizen - is this sufficient, or would accessing getBaseUrl() be more appropriate (in which case can that be exposed back to python in ipypopout)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is a 1 on 1 mapping of where ipypopout and sidecar work. I think sidecar has different requirements than ipypopout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have any suggestions on which conditions to use for each for now then?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3309 +/- ##
=======================================
Coverage 88.81% 88.81%
=======================================
Files 125 125
Lines 19036 19037 +1
=======================================
+ Hits 16906 16907 +1
Misses 2130 2130 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Description
This pull request raises an error when trying to show a widget in popout or sidecar when they are not supported (i.e. in VS Code). Related to #3251.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.