Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Skip chronically failing test #3283

Merged
merged 2 commits into from
Nov 12, 2024
Merged

TST: Skip chronically failing test #3283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76014b2
TST: Skip chronically failing test
pllim Nov 12, 2024
de4b236
Also ignore warning from spacetelescope/gwcs#522
pllim Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion jdaviz/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,11 @@ def load_data(self, file_obj, parser_reference=None, **kwargs):
parser = data_parser_registry.members.get(data_parser)

if parser is not None:
parser(self, file_obj, **kwargs)
with warnings.catch_warnings():
# https://github.com/spacetelescope/gwcs/pull/522
warnings.filterwarnings(
"ignore", message="The bounding_box was set in C order.*")
parser(self, file_obj, **kwargs)
else:
self._application_handler.load_data(file_obj)

Expand Down
7 changes: 6 additions & 1 deletion jdaviz/configs/mosviz/tests/test_parsers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import warnings
from zipfile import ZipFile

import pytest
Expand Down Expand Up @@ -145,7 +146,11 @@ def test_niriss_parser(mosviz_helper, tmp_path):
imview = mosviz_helper.app.get_viewer(mosviz_helper._default_image_viewer_reference_name)
x_pixcenter = (imview.state.x_max + imview.state.x_min)/2.0
y_pixcenter = (imview.state.y_max + imview.state.y_min)/2.0
viewer_center_coord = imview.layers[0].layer.coords.pixel_to_world(x_pixcenter, y_pixcenter)
with warnings.catch_warnings():
# https://github.com/spacetelescope/gwcs/pull/522
warnings.filterwarnings(
"ignore", message="The bounding_box was set in C order.*")
viewer_center_coord = imview.layers[0].layer.coords.pixel_to_world(x_pixcenter, y_pixcenter)
assert_allclose(viewer_center_coord.ra.deg, dc_tab["R.A."][0])
assert_allclose(viewer_center_coord.dec.deg, dc_tab["Dec."][0])

Expand Down
1 change: 1 addition & 0 deletions jdaviz/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ def test_uri_to_download_specviz(specviz_helper, tmp_path):
specviz_helper.load_data(uri, cache=True, local_path=local_path)


@pytest.mark.skip(reason="FIXME: Find a file that is not missing from MAST")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up in https://jira.stsci.edu/browse/JDAT-4921

@pytest.mark.remote_data
def test_uri_to_download_specviz2d(specviz2d_helper, tmp_path):
uri = "mast:JWST/product/jw01324-o006_s00005_nirspec_f100lp-g140h_s2d.fits"
Expand Down
Loading