-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for scientific notation in unit string #3200
add support for scientific notation in unit string #3200
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3200 +/- ##
=======================================
Coverage 88.50% 88.50%
=======================================
Files 124 124
Lines 18577 18579 +2
=======================================
+ Hits 16441 16443 +2
Misses 2136 2136 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - love the simplicity!
@@ -199,6 +199,10 @@ def _return_spectrum_with_correct_units(flux, wcs, metadata, data_type, | |||
if uncertainty is not None: | |||
uncertainty = uncertainty / (u.pix * u.pix) | |||
|
|||
# handle scale factors when they are included in the unit | |||
if not np.isclose(flux.unit.scale, 1.0, rtol=1e-5): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my only concern here is if there was a case that fell within the tolerance because of an actual scale in the unit, but I don't think that's a realistic real-case scenario and this is probably a better idea than checking ==1
anyways.
Description
This pull request is to address when scientific notation (a scale factor), is included in the native unit of the data file parsed (eg. in a MANGA cube). It is addressed by updating the values of the data to reflect the scale factor, and in the Unit Conversion plugin/app-wide, 'removing' the scale factor from the actual unit. When viewing the BUNIT metadata, the scale factor is still included in the unit.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.