Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of concept: color magnitude diagrams from catalogs in Imviz #3093

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bmorris3
Copy link
Contributor

@bmorris3 bmorris3 commented Jul 16, 2024

Description

This proof of concept PR visualizes a linked color magnitude diagram with an image in Imviz. This was developed during the catalog performance hack day.

Screen Shot 2024-07-16 at 15 44 58

This was a two hour hack, and many things could be done correctly if we take up this line of work:

  • the ImvizScatterViewer was adapted from the LCviz TimeScatterViewer. We could develop a generic one that LCviz inherits.
  • the ScatterViewerState is directly copied from LCviz. I would have imported it from LCviz, but LCviz imports jdaviz, so the circular imports made that impossible.
  • we need a data translator for an astropy table, which should go upstream in glue astronomy. I made a TableHandler class here by copying and modifying the LCviz glue translator for lightkurve.LightCurve objects, which are ultimately a specific kind of astropy table.

Demo video

...is too big to embed in GitHub, so watch it via Box: https://stsci.box.com/s/9xzt8367nodxvn15oy9ilohpcot8y7xt

The demo notebook used in the video is located in this PR at notebooks/concepts/imviz-catalog-viewer.ipynb.

@github-actions github-actions bot added documentation Explanation of code and concepts embed Regarding issues with front-end embedding imviz plugin Label for plugins common to multiple configurations labels Jul 16, 2024
@bmorris3 bmorris3 added the proof-of-concept Proof of concept for future reference label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Explanation of code and concepts embed Regarding issues with front-end embedding imviz plugin Label for plugins common to multiple configurations proof-of-concept Proof of concept for future reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant