Skip to content

Commit

Permalink
review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
kecnry committed Jan 16, 2025
1 parent f8f0bc9 commit d3d5033
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 3 additions & 1 deletion CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,13 @@ Cubeviz

- Fixed copious warnings from spaxel tool when data has INF. [#3368]

- Cubeviz-specific helper-level methods are deprecated and will be removed in the future in favor of plugin APIs. [#3388]
- Cubeviz-specific helper-level methods are deprecated and will be removed in the future in favor of plugin APIs as configs are centralized. [#3388]

Imviz
^^^^^

- ``get_aperture_photometry_results`` helper-level method is deprecated and will be removed in the future in favor of plugin APIs as configs are centralized. [#3388]

Mosviz
^^^^^^

Expand Down
6 changes: 3 additions & 3 deletions jdaviz/core/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ def fitted_models(self):
"""
plg = self.plugins.get('Model Fitting', None)
if plg is None:
raise ValueError("Model Fitting plugin does not exist")
raise ValueError("Model Fitting plugins is not loaded")
return plg.fitted_models

@deprecated(since="4.2", alternative="plugins['Model Fitting'].get_models")
Expand Down Expand Up @@ -208,7 +208,7 @@ def get_models(self, models=None, model_label=None, x=None, y=None):
"""
plg = self.plugins.get('Model Fitting', None)
if plg is None:
raise ValueError("Model Fitting plugin does not exist")
raise ValueError("Model Fitting plugins is not loaded")
return plg.get_models(models=models,
model_label=model_label,
x=x, y=y)
Expand Down Expand Up @@ -245,7 +245,7 @@ def get_model_parameters(self, models=None, model_label=None, x=None, y=None):
"""
plg = self.plugins.get('Model Fitting', None)
if plg is None:
raise ValueError("Model Fitting plugin does not exist")
raise ValueError("Model Fitting plugins is not loaded")
return plg.get_model_parameters(models=models,
model_label=model_label,
x=x, y=y)
Expand Down

0 comments on commit d3d5033

Please sign in to comment.