Make sure the removal of the slit patch correctly results in events

spacetelescope · Sep 3, 2021 · 1d0e35b · 1d0e35b
1 parent 1b79541
commit 1d0e35b
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/jdaviz/configs/mosviz/plugins/slit_overlay/slit_overlay.py b/jdaviz/configs/mosviz/plugins/slit_overlay/slit_overlay.py
@@ -132,5 +132,10 @@ def place_slit_overlay(self, *args, **kwargs):
     def remove_slit_overlay(self):
         if self._slit_overlay_mark is not None:
             image_figure = self.app.get_viewer("image-viewer").figure
-            image_figure.marks.remove(self._slit_overlay_mark)
+            # We need to do the following instead of just removing directly on
+            # the marks otherwise traitlets doesn't register a change in the
+            # marks.
+            marks = image_figure.marks.copy()
+            marks.remove(self._slit_overlay_mark)
+            image_figure.marks = marks
             self._slit_overlay_mark = None