Implement new (via image) and maintain old (scalar) saturation image flagging #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be backwards compatible when the SATFILE FITS keyword is missing or contains a bad value in the PHDU of the RAW file.
full-well saturated data is done if the SATFILE keyword is missing or has a bad value.
raswaters
reviewed
Aug 7, 2023
pkg/wfc3/calwf3/lib/dodqi.c
Outdated
| @@ -182,7 +190,16 @@ SingleGroup *x io: image to be calibrated; DQ array written to in-place | |||
| if (wf3->dqicorr != PERFORM && wf3->dqicorr != DUMMY) | |||
| return (status); | |||
|
|
|||
| /* Issue a message so it is clear that saturation flagging is | |||
There was a problem hiding this comment.
Argh - spaces vs tabs. Changed to tabs as the remainder of the file is set. Commit dbc7370.
raswaters
reviewed
Aug 7, 2023
| @@ -194,6 +211,14 @@ SingleGroup *x io: image to be calibrated; DQ array written to in-place | |||
| sum_dq = DQPix (x->dq.data, i, j) | ATODSAT; | |||
| DQSetPix (x->dq.data, i, j, sum_dq); /* atod sat */ | |||
| } | |||
|
|
|||
| if (wf3->scalar_satflag == True) { | |||
There was a problem hiding this comment.
Are lines 215-221 to be executed after lines 210-213, or instead of?
There was a problem hiding this comment.
Lines 215-221 are executed after Lines 210-213.
raswaters
approved these changes
Aug 7, 2023
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed implementation to use an image to detect and flag full-well saturation versus a simple scalar. The new routine, dofwsat.c, is similar to what has been done for calacs. The WFC3 implementation is more complicated in that there are serial virtual overscan columns, as well as binned images, to accommodate. The detection/flagging occurs after blev and bias corrections while the output is still in counts. If the SATUFILE keyword is missing from the FITS header, or the keyword does not have a valid filename as a value, the code will revert to using the original method of flagging full-well saturation. The flagging will be done in doDQI and use a single value as the saturation threshold.