Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrizzlePac notebook dependency updates #301

Merged
merged 12 commits into from
Aug 27, 2024
Merged

Conversation

haticekaratay
Copy link
Collaborator

This pull request updates the dependency pinnings of the DrizzlePac notebooks from their fixed versions. The notebooks have been successfully run locally with a Python 3.12 environment prior to creating this PR.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@haticekaratay haticekaratay requested a review from sosey August 2, 2024 16:22
@haticekaratay
Copy link
Collaborator Author

Hi @sosey, just a heads-up that the only package versions pinned in these notebooks are for photutils, which will be removed once the drizzlepac is released to deal with issues related to deprecated methods in photutils. Additionally, the align_to_catalogs notebook has astroquery pinned due to API changes in the newer releases, so the notebook will need updating later to accommodate this.

Copy link
Member

@sosey sosey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the odd man out numpy setting, looks reasonable.

@haticekaratay haticekaratay merged commit bb21829 into main Aug 27, 2024
14 of 19 checks passed
@haticekaratay haticekaratay deleted the drizzlepac-dependencies branch August 27, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants