-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling Corrections #295
Spelling Corrections #295
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice catch on these 👍🏾
The CI failure is due to the recent changes in photutils from 1.12 to 1.13, as discussed by Larry Bradley on Slack. photutils is not directly called in this notebook, but a function within custom drizzlepac code I believe, and so should not prevent merging. |
@mrevalski, let's pin the photutils for now. This should address the execution failure. |
Hi @haticekaratay, I've pinned the version of photutils and that solved the CI failure. As with my other recent PR #294 I'm not sure if I should have write access to merge the pull request myself. Or should this be allowed once all changes are approved? |
Merging it. |
Hi @FDauphin and @haticekaratay,
I've made several spelling corrections to this notebook, and no changes have been made to the code.
Please let me know if you have any questions!